Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wildcards in dependabot submodule grouping #79

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Use wildcards in dependabot submodule grouping #79

merged 1 commit into from
Jun 14, 2024

Conversation

nwiltsie
Copy link
Member

Alas, #74 did not achieve what I wanted:

/~https://github.com/uclahs-cds/pipeline-recalibrate-BAM/network/updates/842195399

updater | 2024/06/14 22:50:16 INFO <job_842195399> Starting job processing
updater | 2024/06/14 22:50:16 WARN <job_842195399> Please check your configuration as there are groups where no dependencies match:
updater | - pipeline-submodules
updater | 
updater | This can happen if:
updater | - the group's 'pattern' rules are misspelled
updater | - your configuration's 'allow' rules do not permit any of the dependencies that match the group
updater | - the dependencies that match the group rules have been removed from your project
updater | 
updater | 2024/06/14 22:50:17 INFO <job_842195399> Starting grouped update job for uclahs-cds/pipeline-recalibrate-BAM
updater | 2024/06/14 22:50:17 INFO <job_842195399> Found 1 group(s).
updater | 2024/06/14 22:50:17 WARN <job_842195399> Skipping update group for 'pipeline-submodules' as it does not match any allowed dependencies.

I think the issue is that the dependencies are technically labelled as external/pipeline-Nextflow-config and external/pipeline-Nextflow-module, so my patterns did not match. Hopefully adding these wildcards (as detailed in the docs) makes it work correctly.

I don't want to hard-code external/pipeline-Nextflow-config because I want to duplicate these changes across all of our pipelines, and a wildcard would be more convenient for that.

@nwiltsie nwiltsie merged commit a040be0 into main Jun 14, 2024
7 checks passed
@nwiltsie nwiltsie deleted the nwiltsie-dependabot-grouping-again branch June 14, 2024 23:08
@nwiltsie
Copy link
Member Author

Yes! This one worked! #80

@yashpatel6
Copy link
Collaborator

Nice nice, another thing to propagate to other pipelines

This was referenced Jun 14, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashpatel6 yashpatel6 yashpatel6 approved these changes

@tyamaguchi-ucla tyamaguchi-ucla Awaiting requested review from tyamaguchi-ucla tyamaguchi-ucla is a code owner

@Faizal-Eeman Faizal-Eeman Awaiting requested review from Faizal-Eeman Faizal-Eeman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwiltsie @yashpatel6